Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

chore: delete owlbot.py #55

Merged
merged 4 commits into from
Oct 18, 2021
Merged

chore: delete owlbot.py #55

merged 4 commits into from
Oct 18, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 14, 2021 •
edited
Loading

Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.

Closes #56

@parthea parthea requested a review from a team as a code owner October 14, 2021 21:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
@product-auto-label product-auto-label bot added the api: essentialcontacts Issues related to the googleapis/python-essential-contacts API. label Oct 14, 2021
parthea
parthea commented Oct 14, 2021
View reviewed changes
owlbot.py Show resolved Hide resolved
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 14, 2021
@parthea
Copy link
Contributor Author

parthea commented Oct 14, 2021 

Name                                                                                                Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------------------------------------------------------------------
google/cloud/essential_contacts/__init__.py                                                            15     15      0      0     0%   17-37
google/cloud/essential_contacts_v1/__init__.py                                                         15      0      0      0   100%
google/cloud/essential_contacts_v1/services/__init__.py                                                 0      0      0      0   100%
google/cloud/essential_contacts_v1/services/essential_contacts_service/__init__.py                      3      0      0      0   100%
google/cloud/essential_contacts_v1/services/essential_contacts_service/async_client.py                128      2     24      0    99%   698-699
google/cloud/essential_contacts_v1/services/essential_contacts_service/client.py                      225      2     72      0    99%   869-870
google/cloud/essential_contacts_v1/services/essential_contacts_service/pagers.py                       80      0     20      0   100%
google/cloud/essential_contacts_v1/services/essential_contacts_service/transports/__init__.py           9      0      0      0   100%
google/cloud/essential_contacts_v1/services/essential_contacts_service/transports/base.py              65      2     12      0    97%   38-39
google/cloud/essential_contacts_v1/services/essential_contacts_service/transports/grpc.py              82      0     28      0   100%
google/cloud/essential_contacts_v1/services/essential_contacts_service/transports/grpc_asyncio.py      85      0     28      0   100%
google/cloud/essential_contacts_v1/types/__init__.py                                                    2      0      0      0   100%
google/cloud/essential_contacts_v1/types/enums.py                                                      17      0      0      0   100%
google/cloud/essential_contacts_v1/types/service.py                                                    48      0      0      0   100%
tests/unit/__init__.py                                                                                  0      0      0      0   100%
-----------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                 774     21    184      0    98%
Coverage failure: total of 98 is less than fail-under=100

@parthea
Copy link
Contributor Author

parthea commented Oct 14, 2021

Created #56 to track increasing code coverage.

@parthea parthea closed this Oct 14, 2021
@parthea parthea reopened this Oct 16, 2021
@parthea parthea self-assigned this Oct 16, 2021
@parthea
Copy link
Contributor Author

parthea commented Oct 16, 2021

I'm going to update this PR to include the .coveragerc file from the microgenerator here:
https://github.com/googleapis/googleapis-gen/blob/master/google/cloud/essentialcontacts/v1/essentialcontacts-v1-py/.coveragerc

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 16, 2021
@parthea parthea removed their assignment Oct 16, 2021
@busunkim96 busunkim96 merged commit 7f0480b into main Oct 18, 2021
@busunkim96 busunkim96 deleted the delete-owlbot-py branch October 18, 2021 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: essentialcontacts Issues related to the googleapis/python-essential-contacts API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase code coverage from 98% to 100%
2 participants
@parthea @busunkim96